Use decodeURIComponent to fix error: "SyntaxError: Unexpected token '%'" #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PRs decodes the data portion of the worker script before executing this in NodeJS. Worth noting that
decodeURIComponent
on a normal text or base64 encoding is idempotent so this change shouldn't affect other cases.Also the browser itself probably does such decoding automatically when loading workers.
More details
I discovered this issue when trying to use this
web-worker
package along with webpack worker-loader syntax. For example, if I have a worker defined like this:Then I get the following error coming from web-worker package:
It looks like webpack URI-encodes the worker script before sending it.
The same worker script looks totally reasonable after decoding:
and the above PR fixes my issue.