Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial support for visionOS. #391

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Zandor300
Copy link
Member

Implements initial support for visionOS. The goals is to have DeviceKit the current device as an "Apple Vision Pro" but not yet add any visionOS specific extra features.

Fixes #387

Copy link

github-actions bot commented Feb 6, 2024

1 Warning
⚠️ Plist changed, don't forget to localize your plist values

Generated by 🚫 Danger

@denandreychuk
Copy link

Did you test it on real vision pro device? Cause RealityDevice14,1 seems like a wrong identifier for a real one:
https://stackoverflow.com/a/76777118

Check last comment:

Unfortunately, this solution doesn't seem to work on a real device. We don't have one to check for sure, but our app didn't pass a compatibility check at Apple - the app tries to use unavailable APIs which we have restricted on Vision Pro, but the device check fails

@Zandor300
Copy link
Member Author

@denandreychuk I live in EU and so am unable to get ahold of a physical device. (Would if I could)

This PR is still a draft, if someone with an actual device could possibly join in that would be really great!

@denandreychuk
Copy link

denandreychuk commented Feb 8, 2024

For everyone who is wondering, the device name for the real Vision Pro is iPad13,4. It has a .front camera, but does not have a .rear camera for UIImagePickerController.isCameraDeviceAvailable.

@Zandor300
Copy link
Member Author

@denandreychuk Isn’t that the case when running in the “Vision Pro (made for iPad)” mode? This PR is intended for apps built specifically for visionOS without any iPadOS to visionOS translation.

@denandreychuk
Copy link

denandreychuk commented Feb 8, 2024

Oh, I see. Yeah, this is when the app running in compatible mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Apple Vision Pro
2 participants