camel case map key formatting #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinus
force-pushed
the
master
branch
2 times, most recently
from
ee06841
to
ee8336f
Compare
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
devinus
force-pushed
the
master
branch
22 times, most recently
from
29a475d
to
e0a080a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @devinus , I followed the discussion in #44 and https://github.com/devinus/poison/pull/60/files and tried a different approach for a camelCased map keys option when serializing only.
I tried to avoid callbacks and kept original default code paths unchanged to make sure performance is not impacted in the default case.
Would really like for this to be part of poison, so any changes in coding style or the approach you need done I'll happily do