ci: add python 3.10, gcc-10 option #1795
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
- Coverage 89.55% 87.37% -2.18%
==========================================
Files 209 204 -5
Lines 34062 33584 -478
Branches 4418 4413 -5
==========================================
- Hits 30504 29345 -1159
- Misses 3062 3729 +667
- Partials 496 510 +14
Continue to review full report at Codecov.
|
|
scipy doesn't support 3.10 and numpy only in some case so until these move towards it I wouldn't even look at it. |
|
makes sense |
|
Looks liek scipy got a new release 3 days ago that support 3.10 |
| - name: pytest-docker-py36-gcc-omp | ||
| python-version: 3.6 | ||
| os: ubuntu-18.04 | ||
| - name: pytest-docker-py310-gcc-omp |
There was a problem hiding this comment.
I wouldn't change the docker build we wanna keep a safe standard version for that one.
georgebisbas
force-pushed
the
python3.10
branch
from
23ac27c
to
668a101
Compare
| ] | ||
| set: [base, adjoint] | ||
| include: | ||
| - name: pytest-ubuntu-py37-gcc5-omp | ||
| python-version: 3.7 | ||
| python-version: '3.7' |
There was a problem hiding this comment.
why do we need the '...' now?
| os: ubuntu-20.04 | ||
| arch: "gcc-9" | ||
| language: "openmp" | ||
| sympy: 1.8 | ||
|
|
||
| - name: pytest-ubuntu-py310-gcc10-omp |
There was a problem hiding this comment.
adding a new one, but not dropping an old one? is this PR replacing a job, or adding a new one?
There was a problem hiding this comment.
We discused in the meeting yesterday to maybe replace a 3.7 job, ' ' are needed from now on for github actions.
There was a problem hiding this comment.
|
why is the docker build also changing? |
It had wrong name before... now it is fixed. It is using 3.7 |
mloubout
force-pushed
the
python3.10
branch
2 times, most recently
from
81b921e
to
3d00e0b
Compare
Tested python 3.10 via docker seems ok, just spinning a python 3.10 CI