API: Fix Sparse rebuild with explicit empty subfunctions #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
sparse-subfunc-init
branch
3 times, most recently
from
38ffc2c
to
c3da175
Compare
devito/types/sparse.py
Outdated
| kwargs.get('interpolation_coeffs_data')) | ||
| if not any(k in kwargs for k in ('coordinates', 'gridpoints', | ||
| 'coordinates_data', 'gridpoints_data')): | ||
| print(kwargs) |
devito/types/sparse.py
Outdated
| def __subfunc_setup__(self, suffix, keys, dtype=None, inkwargs=False, **kwargs): | ||
| key = None | ||
| for k in keys: | ||
| if k in kwargs: |
There was a problem hiding this comment.
multiple indentation levels avoidable, I think:
if k not in kwargs:
continue
elif kwargs[k] is None:
return None
else:
key = kwargs[k]
break
...
devito/types/sparse.py
Outdated
| return None | ||
| else: | ||
| if inkwargs: | ||
| # Only create the subfunction if provided. |
There was a problem hiding this comment.
not sure I understand what the role of this argument is, perhaps expand the comment?
mloubout
force-pushed
the
sparse-subfunc-init
branch
from
c3da175
to
32f9b30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2473 +/- ##
=======================================
Coverage 87.19% 87.20%
=======================================
Files 238 238
Lines 45185 45201 +16
Branches 4008 4012 +4
=======================================
+ Hits 39400 39418 +18
+ Misses 5104 5103 -1
+ Partials 681 680 -1 ☔ View full report in Codecov by Sentry. |
mloubout
force-pushed
the
sparse-subfunc-init
branch
from
32f9b30
to
8dbe997
Compare
mloubout
force-pushed
the
sparse-subfunc-init
branch
from
8dbe997
to
898dd73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.