Merge pull request #83 from pimterry/fixSilverlightMockNames

Fix mock naming code & tests in Silverlight
devlooped · Jan 11, 2014 · 87cdb7e · 87cdb7e
2 parents 3c3eab9 + 4f0925d
commit 87cdb7e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/Source.Silverlight/Moq.Silverlight.csproj b/Source.Silverlight/Moq.Silverlight.csproj
@@ -358,6 +358,9 @@
     <Compile Include="..\Source\Proxy\IProxyFactory.cs">
       <Link>Poxy\IProxyFactory.cs</Link>
     </Compile>
+    <Compile Include="..\Source\Proxy\ProxyGenerationHelpers.cs">
+      <Link>Poxy\ProxyGenerationHelpers.cs</Link>
+    </Compile>
     <Compile Include="..\Source\Range.cs">
       <Link>Range.cs</Link>
     </Compile>
@@ -414,4 +417,4 @@
       </FlavorProperties>
     </VisualStudio>
   </ProjectExtensions>
-</Project>
+</Project>
diff --git a/Source/Mock.Generic.cs b/Source/Mock.Generic.cs
@@ -39,16 +39,18 @@
 // http://www.opensource.org/licenses/bsd-license.php]
 
 using System;
-using System.CodeDom;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq.Expressions;
-using Microsoft.CSharp;
 using Moq.Language.Flow;
 using Moq.Proxy;
 using Moq.Language;
-using Moq.Properties;
 using System.Reflection;
 
+#if !SILVERLIGHT
+using System.CodeDom;
+using Microsoft.CSharp;
+#endif
+
 namespace Moq
 {
 	/// <include file='Mock.Generic.xdoc' path='docs/doc[@for="Mock{T}"]/*'/>
@@ -120,6 +122,7 @@ private string GenerateMockName()
 
 			var typeName = typeof (T).FullName;
 
+#if !SILVERLIGHT
 			if (typeof (T).IsGenericType)
 			{
 				using (var provider = new CSharpCodeProvider())
@@ -128,6 +131,7 @@ private string GenerateMockName()
 					typeName = provider.GetTypeOutput(typeRef);
 				}
 			}
+#endif
 
 			return "Mock<" + typeName + ":" + randomId + ">";
 		}

diff --git a/UnitTests/MockFixture.cs b/UnitTests/MockFixture.cs
@@ -1,5 +1,4 @@
 using System;
-using System.Collections;
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using Xunit;
@@ -45,13 +44,15 @@ public void HasADefaultNameThatIncludesItsTypeAndThatItsAMock()
 			Assert.Contains("mock", mock.ToString().ToLower());
 		}
 
+#if !SILVERLIGHT
 		[Fact]
 		public void HasADefaultNameThatIncludesItsGenericParameters()
 		{
 			var mock = new Mock<Dictionary<int, string>>();
 
 			Assert.Contains("System.Collections.Generic.Dictionary<int, string>", mock.ToString());
 		}
+#endif
 
 		[Fact]
 		public void PassesItsNameOnToTheResultingMockObjectWhenMockingInterfaces()
@@ -64,7 +65,7 @@ public void PassesItsNameOnToTheResultingMockObjectWhenMockingInterfaces()
 		[Fact]
 		public void PassesItsNameOnToTheResultingMockObjectWhenMockingClasses()
 		{
-			var mock = new Mock<ArrayList>();
+			var mock = new Mock<Foo>();
 
 			Assert.Equal(mock.ToString() + ".Object", mock.Object.ToString());
 		}