Improve performance for mocking interfaces: Cache GetInterfaceMap

Fixes #1350.
devlooped · Jul 10, 2023 · d6997f7 · d6997f7
1 parent 02b798a
commit d6997f7
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/Moq/Extensions.cs b/src/Moq/Extensions.cs
@@ -2,6 +2,7 @@
 // All rights reserved. Licensed under the BSD 3-Clause License; see License.txt.
 
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
@@ -134,7 +135,7 @@ public static MethodInfo GetImplementingMethod(this MethodInfo method, Type prox
 			{
 				Debug.Assert(declaringType.IsAssignableFrom(proxyType));
 
-				var map = proxyType.GetInterfaceMap(method.DeclaringType);
+				var map = GetInterfaceMap(proxyType, method.DeclaringType);
 				var index = Array.IndexOf(map.InterfaceMethods, method);
 				Debug.Assert(index >= 0);
 				return map.TargetMethods[index].GetBaseDefinition();
@@ -151,6 +152,13 @@ public static MethodInfo GetImplementingMethod(this MethodInfo method, Type prox
 			}
 		}
 
+		private static readonly ConcurrentDictionary<Tuple<Type, Type>, InterfaceMapping> mappingsCache = new ();
+
+		private static InterfaceMapping GetInterfaceMap(Type type, Type interfaceType)
+		{
+			return mappingsCache.GetOrAdd(Tuple.Create(type, interfaceType), tuple => tuple.Item1.GetInterfaceMap(tuple.Item2));
+		}
+
 		public static object InvokePreserveStack(this Delegate del, IReadOnlyList<object> args = null)
 		{
 			try