New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw away generic type arguments in one `mock.Protected().Verify<T>()` method overload #1325

Merged

stakx merged 3 commits into devlooped:main from stakx:bugfix/verify-protected-generic-non-void-method

Jan 13, 2023

Contributor

stakx commented Jan 13, 2023

Fixes #1314.

stakx force-pushed the bugfix/verify-protected-generic-non-void-method branch from 2a09be5 to 24dd285 Compare

January 13, 2023 17:00

stakx added 3 commits

January 13, 2023 18:01


          Add failing test for one mock.Protected().Verify<T>() method overload

a1eaac6


          Don't throw away generic type arguments in impl

caca113


          Update the changelog

4240ff4

stakx force-pushed the bugfix/verify-protected-generic-non-void-method branch from 24dd285 to 4240ff4 Compare

January 13, 2023 17:02

stakx added this to the 4.19.0 milestone

stakx merged commit 1c4c723 into devlooped:main

stakx deleted the bugfix/verify-protected-generic-non-void-method branch

January 13, 2023 17:17

vbreuss referenced this pull request in Testably/Testably.Architecture.Rules


          chore(deps): update dependency moq to v4.20.0 (#83)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Moq](https://togithub.com/moq/moq) | nuget | minor | `4.18.4` ->
`4.20.0` |

---

### Release Notes

<details>
<summary>moq/moq (Moq)</summary>

### [`v4.20.0`](https://togithub.com/moq/moq/releases/tag/v4.20.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### ✨ Implemented enhancements

- Add `setup.Verifiable(Times times, [string failMessage])` method by
[@&#8203;stakx](https://togithub.com/stakx) in
[https://github.com/moq/moq/pull/1319](https://togithub.com/moq/moq/pull/1319)

##### 🔨 Other

- Add `Mock<T>.RaiseAsync` by
[@&#8203;stakx](https://togithub.com/stakx) in
[https://github.com/moq/moq/pull/1313](https://togithub.com/moq/moq/pull/1313)
- Add `ThrowsAsync` for non-generic `ValueTask` by
[@&#8203;johnthcall](https://togithub.com/johnthcall) in
[https://github.com/moq/moq/pull/1235](https://togithub.com/moq/moq/pull/1235)
- Use PackageLicenseExpression instead of PackageLicenseUrl by
[@&#8203;wismann](https://togithub.com/wismann) in
[https://github.com/moq/moq/pull/1322](https://togithub.com/moq/moq/pull/1322)
- Don't throw away generic type arguments in one
`mock.Protected().Verify<T>()` method overload by
[@&#8203;stakx](https://togithub.com/stakx) in
[https://github.com/moq/moq/pull/1325](https://togithub.com/moq/moq/pull/1325)
- [#&#8203;1340](https://togithub.com/moq/moq/issues/1340) updated
appveyor.yml with workaround to make builds work again by
[@&#8203;david-kalbermatten](https://togithub.com/david-kalbermatten) in
[https://github.com/moq/moq/pull/1346](https://togithub.com/moq/moq/pull/1346)
- Revamp structure, apply oss template, cleanup projects/imports by
[@&#8203;kzu](https://togithub.com/kzu) in
[https://github.com/moq/moq/pull/1358](https://togithub.com/moq/moq/pull/1358)
- Add 💜 SponsorLink support by [@&#8203;kzu](https://togithub.com/kzu)
in
[https://github.com/moq/moq/pull/1363](https://togithub.com/moq/moq/pull/1363)
- fix website url by [@&#8203;tibel](https://togithub.com/tibel) in
[https://github.com/moq/moq/pull/1364](https://togithub.com/moq/moq/pull/1364)

#### New Contributors

- [@&#8203;johnthcall](https://togithub.com/johnthcall) made their first
contribution in
[https://github.com/moq/moq/pull/1235](https://togithub.com/moq/moq/pull/1235)
- [@&#8203;wismann](https://togithub.com/wismann) made their first
contribution in
[https://github.com/moq/moq/pull/1322](https://togithub.com/moq/moq/pull/1322)
- [@&#8203;david-kalbermatten](https://togithub.com/david-kalbermatten)
made their first contribution in
[https://github.com/moq/moq/pull/1346](https://togithub.com/moq/moq/pull/1346)
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[https://github.com/moq/moq/pull/1360](https://togithub.com/moq/moq/pull/1360)

**Full Changelog**: moq/moq.spikes@v4.18.4...v4.20.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Architecture.Rules).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

vbreuss referenced this pull request in Testably/Testably.Abstractions


          chore(deps): update dependency moq to v4.20.0 (#351)

6bb6080

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Moq](https://togithub.com/moq/moq) | nuget | minor | `4.18.4` ->
`4.20.0` |

---

### Release Notes

<details>
<summary>moq/moq (Moq)</summary>

### [`v4.20.0`](https://togithub.com/moq/moq/releases/tag/v4.20.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### ✨ Implemented enhancements

- Add `setup.Verifiable(Times times, [string failMessage])` method by
[@&#8203;stakx](https://togithub.com/stakx) in
[https://github.com/moq/moq/pull/1319](https://togithub.com/moq/moq/pull/1319)

##### 🔨 Other

- Add `Mock<T>.RaiseAsync` by
[@&#8203;stakx](https://togithub.com/stakx) in
[https://github.com/moq/moq/pull/1313](https://togithub.com/moq/moq/pull/1313)
- Add `ThrowsAsync` for non-generic `ValueTask` by
[@&#8203;johnthcall](https://togithub.com/johnthcall) in
[https://github.com/moq/moq/pull/1235](https://togithub.com/moq/moq/pull/1235)
- Use PackageLicenseExpression instead of PackageLicenseUrl by
[@&#8203;wismann](https://togithub.com/wismann) in
[https://github.com/moq/moq/pull/1322](https://togithub.com/moq/moq/pull/1322)
- Don't throw away generic type arguments in one
`mock.Protected().Verify<T>()` method overload by
[@&#8203;stakx](https://togithub.com/stakx) in
[https://github.com/moq/moq/pull/1325](https://togithub.com/moq/moq/pull/1325)
- [#&#8203;1340](https://togithub.com/moq/moq/issues/1340) updated
appveyor.yml with workaround to make builds work again by
[@&#8203;david-kalbermatten](https://togithub.com/david-kalbermatten) in
[https://github.com/moq/moq/pull/1346](https://togithub.com/moq/moq/pull/1346)
- Revamp structure, apply oss template, cleanup projects/imports by
[@&#8203;kzu](https://togithub.com/kzu) in
[https://github.com/moq/moq/pull/1358](https://togithub.com/moq/moq/pull/1358)
- Add 💜 SponsorLink support by [@&#8203;kzu](https://togithub.com/kzu)
in
[https://github.com/moq/moq/pull/1363](https://togithub.com/moq/moq/pull/1363)
- fix website url by [@&#8203;tibel](https://togithub.com/tibel) in
[https://github.com/moq/moq/pull/1364](https://togithub.com/moq/moq/pull/1364)

#### New Contributors

- [@&#8203;johnthcall](https://togithub.com/johnthcall) made their first
contribution in
[https://github.com/moq/moq/pull/1235](https://togithub.com/moq/moq/pull/1235)
- [@&#8203;wismann](https://togithub.com/wismann) made their first
contribution in
[https://github.com/moq/moq/pull/1322](https://togithub.com/moq/moq/pull/1322)
- [@&#8203;david-kalbermatten](https://togithub.com/david-kalbermatten)
made their first contribution in
[https://github.com/moq/moq/pull/1346](https://togithub.com/moq/moq/pull/1346)
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[https://github.com/moq/moq/pull/1360](https://togithub.com/moq/moq/pull/1360)

**Full Changelog**: moq/moq.spikes@v4.18.4...v4.20.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

devlooped locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet