Issue #249 #28
Closed
Issue #249 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, I fix the problem and I try to do this pull request from scratch in order to see if issues disappear. |
|
|
||
| // Special case for events. | ||
| if (!FluentMockContext.IsActive) | ||
| lock (Mock) // this solves issue #249, but actually worsen method complexity :( |
There was a problem hiding this comment.
This doesn't really "fix" multi-threading issues; it avoids them; breaking any actual required use of concurrency by forcing them not to overlap. I've raised Issue #62 about this 👎 We've had to roll back to 4.0 for our concurrency tests to work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will solve the Issue #249 ( thread safety ). I branched out all other modification I have on my repository so the merge should be easy. The only thing "exogenous" to the pure issue soving is a compilation flag ( *HAVEOFFICE *) I added in order to compile the whole solution even if no office interop are available.