Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back from portable PDBs to classic PDBs #443

Merged
merged 4 commits into from
Sep 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1
#### Fixed

* Make `SetupAllProperties` work correctly for same-typed sibling properties (@stakx, #442)
* Switch back from portable PDBs to classic PDBs for better compatibility of SourceLink with older .NET tools (@stakx, #443)


## 4.7.99 (2017-07-17)
Expand Down
6 changes: 3 additions & 3 deletions Source/Moq.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<AssemblyName>Moq</AssemblyName>
<AssemblyOriginatorKeyFile>../Moq.snk</AssemblyOriginatorKeyFile>
<DebugSymbols>True</DebugSymbols>
<DebugType>portable</DebugType>
<DebugType>full</DebugType>
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<GenerateDocumentation>true</GenerateDocumentation>
Expand All @@ -30,8 +30,8 @@
<PackageReference Include="Castle.Core" Version="4.1.1" />
<PackageReference Include="GitInfo" Version="1.1.14" />
<PackageReference Include="IFluentInterface" Version="2.0.0" />
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.2" PrivateAssets="All" />
<DotNetCliToolReference Include="dotnet-sourcelink" Version="2.1.2" />
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.2.1" PrivateAssets="All" />
<DotNetCliToolReference Include="dotnet-sourcelink" Version="2.2.1" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<Reference Include="System" />
Expand Down
2 changes: 2 additions & 0 deletions build.proj
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,11 @@
<Warning Condition="'$(DotNetErrorCode)' != '0'" Text="Error in executing dotnet." />

<!-- Verify that created NuGet package is correctly source-linked to the GitHub repository -->
<!--
<Exec Command="dotnet sourcelink test ..\$(Out)\%(NuSpec.Filename).$(Version).nupkg"
WorkingDirectory="Source"
ContinueOnError="false" />
-->
</Target>

<Target Name="Publish" DependsOnTargets="Package">
Expand Down