Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependency on System.ValueTuple to version 4.4.0 #591

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Upgrade dependency on System.ValueTuple to version 4.4.0 #591

merged 2 commits into from
Feb 23, 2018

Commits on Feb 23, 2018

  1. Upgrade System.ValueTuple package to 4.4.0 

    Version 4.3.0 doesn't properly support .NET Framework 4.7+, which
already include the `ValueTuple` types and don't play well with
a package that tries to re-define the same types.

I've run some tests for the following target frameworks, and it seems
that upgrading this package won't cause the kind of assembly version
conflicts we had when upgrading System.Threading.Tasks.Extensions to
4.4.0:

 * netcoreapp1.0
 * netcoreapp2.0
 * net45
 * net451
 * net452
 * net46
 * net461
 * net47
 * net471

If versioning conflicts will pop up despite these tests, we'll have to
multi-target Moq to `net47` as well and thereby blow up NuGet package
size even more. Hopefully that won't be necessary.
    @stakx
    stakx committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    afd660d View commit details
    Browse the repository at this point in the history

  2. Update the changelog

    @stakx
    stakx committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    f9b3d47 View commit details
    Browse the repository at this point in the history