Replace .ToLambda()
conversions with static typing
#629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first out of several refactorings that attempt to get rid (as much as possible) of chained expression transforms such as
.PartialMatcherAwareEval().ToLambda()
which are found all over the codebase. They are problematic because it's not immediately clear when these transforms are needed, and which of them are needed for what reasons..ToLambda()
is a mix-up of two separate concerns:Expression
toLambdaExpression
As it turns out, (1) becomes superfluous if we simply re-declare certain members as
LambdaExpression
instead ofExpression
. Incidentally, this makes visible the heretofore unstated expectation thatMethodCall.SetupExpression
be a lambda expression.ToLambda
is then renamed toStripConversion
to better reflect its remaining function (2).