Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SetupAllProperties to override pre-existing property setups (#837) #840

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Fix SetupAllProperties to override pre-existing property setups (#837) #840

merged 1 commit into from
Jun 2, 2019

Conversation

ishimko
Copy link
Contributor

@ishimko ishimko commented Jun 2, 2019

Fix #837.

No changelog entry here, because the fix is not against existing version, but against unreleased one.

stakx
stakx approved these changes Jun 2, 2019
View reviewed changes
Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you once again! I'm glad this turned out to be a relatively easy fix.

@stakx stakx added this to the 4.11.1 milestone Jun 2, 2019
@stakx stakx merged commit d336df4 into devlooped:master Jun 2, 2019
@stakx stakx modified the milestones: 4.11.1, 4.12.0 Jun 2, 2019
@devlooped devlooped locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stakx stakx stakx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

SetupAllProperties no longer overrides pre-existing property setups
2 participants
@ishimko @stakx