Expose Mock.Setups
, part 6: Replace OriginalSetup
with simpler OriginalExpression
#999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a follow-up to #995.)
There are several problems with the current
ISetup ISetup.OriginalSetup { get; }
:The
IFluentSetup
s that can be returned via this property aren't really working setups; they're inert data objects used mostly for introspection. This means we have several things in the code base that call themselves "setups", yet are basically apples and oranges.Setup expressions are always lambdas. This may be too restrictive if at a later time we e.g. want to link stubbed property accessor setups to a specific
mock.SetupAllProperties()
call.IFluentSetup
may simply be quite difficult to understand; also, it might not be obvious that there's more functionality available when explicitly castingOriginalSetup
toIFluentSetup
.For those reasons, let's replace
OriginalSetup
with a much simpler solution: aExpression OriginalExpression { get; }
property, which should be sufficient in most scenarios and is quite easy to grasp.