Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for windows terminal #701

Closed
hohwille opened this issue Feb 7, 2022 · 4 comments · Fixed by #725
Closed

Support for windows terminal #701

hohwille opened this issue Feb 7, 2022 · 4 comments · Fixed by #725
Assignees
Labels
bash related to bash shell or scripts enhancement New feature or request powershell specific for Microsoft PowerShell windows specific for Microsoft Windows OS

Comments

@hohwille
Copy link
Member

hohwille commented Feb 7, 2022

As a devonfw-ide user on windows, I want to make use of microsoft Terminal app so that I get all my shell sessions as tabs in one window.
Therefore devonfw-ide should notice if Terminal app is installed on windows and if so instead of installing the regular context menu entries like "open devonfw CMD here" install something like this but with full devonfw-ide integration setting up the environment:
https://github.com/lextm/windowsterminal-shell
So as a result in Windows Explorer I would have additional options in the context menu "Open devonfw «Shell-Type» in Windows-Terminal here".
The first step is to implement this for CMD.
For GitBash we created #692
For PowerShell we created #786

@hohwille hohwille added enhancement New feature or request windows specific for Microsoft Windows OS bash related to bash shell or scripts powershell specific for Microsoft PowerShell labels Feb 7, 2022
@hohwille
Copy link
Member Author

hohwille commented Feb 7, 2022

Please note that for the current approach we have *.reg files that get imported into the registry:
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/system/windows/cmd/devon-cmd.reg

We can keep this approach and do not have to copy the linked powershell script solution but just get some inspirations from there.

@hohwille
Copy link
Member Author

hohwille commented Feb 7, 2022

TDB: Maybe if we rather recommend to use git-bash and get used to it, we should focus on that. The context-menu with sub-menu-entries appears nice in the first place but requires additional attention/selection each time so a single flat entry might still be the best option for power-users. Also we should add a small devonfw icon for our menu entry to make it fancy.

@hohwille
Copy link
Member Author

hohwille commented Feb 7, 2022

See also microsoft/terminal#7452

@CREITZ25
Copy link
Member

I have installed Windows the Terminal and created registry keys for the context menu. Applications can be started in different tabs, and now the correct directory has to be given and the devon configuration file has to be executed at start.

CREITZ25 added a commit that referenced this issue Apr 7, 2022
#701 Support for Windows Terminal
@hohwille hohwille linked a pull request May 3, 2022 that will close this issue
CREITZ25 added a commit that referenced this issue May 23, 2022
#701 Support for Windows Terminal
CREITZ25 added a commit that referenced this issue May 23, 2022
#701 Support for Windows Terminal
@hohwille hohwille added this to the release:2022.04.001 milestone May 24, 2022
CREITZ25 added a commit that referenced this issue Jul 20, 2022
#701 Support for Windows Terminal

corrected the path to the reg files
CREITZ25 added a commit that referenced this issue Aug 24, 2022
Bugfix Title of the Window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts enhancement New feature or request powershell specific for Microsoft PowerShell windows specific for Microsoft Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants