Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeshark has switched to version with "v" and #251

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xx4h
Copy link
Contributor

@xx4h xx4h commented Mar 22, 2024

minor version in the naming staring with version v51.0.0

@xx4h xx4h force-pushed the fix-kubeshark-fetch-url branch 2 times, most recently from 4b1735d to 20d420b Compare March 23, 2024 14:28
@xx4h
Copy link
Contributor Author

xx4h commented Mar 23, 2024

depends on #252

@leucos
Copy link
Contributor

leucos commented Mar 23, 2024

Thanks a lot !
Looking at #252

minor version in the naming staring with version v51.0.0
@leucos
Copy link
Contributor

leucos commented Apr 15, 2024

minor version in the naming staring with version v51.0.0

This change will break installing versions before v51.0.0

I guess that with #252 this comment does not apply anymore ?

@xx4h
Copy link
Contributor Author

xx4h commented Apr 16, 2024

minor version in the naming staring with version v51.0.0
This change will break installing versions before v51.0.0

I guess that with #252 this comment does not apply anymore ?

That's true. The last force-pushed update (aae4ebc) does adapt the commit message. Unfortunately this is not reflected in the description of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants