Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Change from png to jpg for images as much as possible #150

Closed
1 task done
mattstratton opened this issue Jan 31, 2017 · 7 comments
Closed
1 task done

Change from png to jpg for images as much as possible #150

mattstratton opened this issue Jan 31, 2017 · 7 comments
Assignees
Milestone

Comments

@mattstratton
Copy link
Member

mattstratton commented Jan 31, 2017

I believe that jpg's are smaller, and we definitely should allow for the ability to use them.

- [ ] Modify the sponsor files to take an optional parameter of image name
- [ ] Modify the sponsor display code to show the optional image name if it is specified

  • Confirm that speakers take a filename and don't try to puzzle it out for the image name
@mattstratton mattstratton self-assigned this Jan 31, 2017
@mattstratton mattstratton added this to the v1.0 Release milestone Jan 31, 2017
@mattstratton
Copy link
Member Author

The downside of using JPG for logos is that it doesn't support transparency. I think that for photos (speakers, etc) they should be JPG.

For example, the apple-jack.png file is 292kb, but as a jpg with 80% quality, it is 109kb.

@mattstratton
Copy link
Member Author

Similarly, the ponyville logo-square is about half the size when it is a jpg.

@bridgetkromhout
Copy link
Contributor

I made some updates you may want to consider here, @mattstratton - I didn't change ponyville/hoofington though.

@mattstratton
Copy link
Member Author

I am pretty sure that I want to keep sponsors the way they are for now; they tend to be small enough images that they aren't a problem, and transparency is helpful.

@bridgetkromhout
Copy link
Contributor

show the optional image name if it is specified

While we're at it, can we add an alt tag for screenreaders?

@mattstratton
Copy link
Member Author

Yeah, I've noticed that we have missed a lot of those. I'll fix in #217

@mattstratton
Copy link
Member Author

Now that I think I fixed all the alt images, and we are gonna keep sponsors the way they are, I think this can be closed.

@ghost ghost removed the in progress label Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants