Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homepage logos for any upcoming events (for devopsdays-theme release) #1499

Closed
mattstratton opened this issue Dec 9, 2016 · 7 comments · Fixed by #1717
Closed

Add homepage logos for any upcoming events (for devopsdays-theme release) #1499

mattstratton opened this issue Dec 9, 2016 · 7 comments · Fixed by #1717
Assignees
Milestone

Comments

@mattstratton
Copy link
Member

See devopsdays/devopsdays-theme#49 for details

@mattstratton mattstratton added this to the 3.0 milestone Dec 9, 2016
@mattstratton
Copy link
Member Author

Actually, see devopsdays/devopsdays-theme#81 for details.

@mattstratton
Copy link
Member Author

Long story short - if they have a logo, crop it to 500px square and dump it into static/events/YYYY-CITY/logo-square.png

If they don't, grab it from twitter.

@bridgetkromhout
Copy link
Collaborator

  • I've got reasonable-ish logos for almost all of them (Los Angeles doesn't have a twitter account or a logo).
  • I didn't try to make them all exactly 500px - does that matter?
  • I did change all of them to jpgs as discussed in Change from png to jpg for images as much as possible devopsdays-theme#150.
  • Are we actually going to need to name the file in every event's yaml? Wouldn't a default with an override-if-desired make sense?

@bridgetkromhout
Copy link
Collaborator

@mattstratton Thanks for approving the merge - I forgot to name you in the questions above.

@mattstratton
Copy link
Member Author

The file check is actually pretty annoying, code-wise, and I like people having the flexibility to name it whatever they want. I think if it's the default option in the generator, it's not that big of a deal.

@mattstratton
Copy link
Member Author

I might start resizing smaller than 500 px square because that might be a little too big. But it should probably be fine.

@bridgetkromhout
Copy link
Collaborator

The file check is actually pretty annoying, code-wise, and I like people having the flexibility to name it whatever they want. I think if it's the default option in the generator, it's not that big of a deal.

Okay. Then I think a to-do before this is :shipit: is for me to add the relevant line to every 2017 event's yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants