This repository has been archived by the owner on Jul 21, 2019. It is now read-only.
Regression on ability to control sponsor ship links #387
Assignees
Labels
Comments
|
The really odd thing is that we literally copy-pasted the code from the old theme for the sponsors partial. Hmm. |
|
Oof. I see the problem. We used to display the "become a sponsor" AFTER the sponsors were listed, so the counting is jacked up. Hmm. |
mattstratton
added a commit
that referenced
this issue
Mar 16, 2017
Fixes #387 Signed-off-by: Matt Stratton <[email protected]>
ghost
assigned
mattstratton
added a commit
that referenced
this issue
Mar 16, 2017
Fixes #387 Signed-off-by: Matt Stratton <[email protected]>
mattstratton
added a commit
that referenced
this issue
Mar 16, 2017
**Fixed bugs:** - Alt text on organizer images needs fixing [\#388](#388) - Regression on ability to control sponsor ship links [\#387](#387) Signed-off-by: Matt Stratton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
"Become a sponsor" should not display if "max set" has been achieved.
Actual behavior
Regardless of the setting, it displays "become a sponsor"
Reproduction Steps
Example is on https://www.devopsdays.org/events/2017-amsterdam where we have a max of 1 set for the evening slot (which under the old layout didn't show "Become a sponsor") but now does.
Reported by @yvovandoorn
The text was updated successfully, but these errors were encountered: