Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

check for organizer image files if they are claimed to exist #573

Open
bridgetkromhout opened this issue Jun 28, 2017 · 6 comments
Open

Comments

@bridgetkromhout
Copy link
Contributor

Expected behavior

If organizer images don't exist in the repo, don't try to show them (even if the config yml claims they exist).

Actual behavior

Broken images:

screen shot 2017-06-28 at 10 56 05 am

Reproduction Steps

Claim organizer image exists but don't put it in repo.

@mattstratton mattstratton modified the milestone: 1.13 Jun 28, 2017
@mattstratton
Copy link
Member

This likely should be extended to include speaker images, as well as sharing images (and some others that it hasn't occurred to me yet).

@bridgetkromhout
Copy link
Contributor Author

Makes sense!

@somatorio
Copy link

i can help with that :)
just a question, what do you think is better: fail silently simply skipping the img tag or use errorf to make an error log and fail the build?

i'm tending to fail the build, but i think it's always better to ask when in doubt

somatorio added a commit to somatorio/devopsdays-theme that referenced this issue Oct 25, 2018
@bridgetkromhout
Copy link
Contributor Author

I am not sure we'd want to fail a build - I'd rather display a default image (which, if they don't like, they can replace).

@mattstratton
Copy link
Member

We wouldn't fail the build if they left off an image - we fail it if they enter an image in the config but then the image is not there (i.e., I specify matt-stratton.png but forget to put the file in the repo, or misspell the file name, etc).

So I vote for failing the build. It's an error that is being caught, so it should fail.

@somatorio
Copy link

yeah, if the image is not set at data/events/yyyy-city.yml the theme already uses a default image as far as i could see :)

somatorio added a commit to somatorio/devopsdays-theme that referenced this issue Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants