Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

single-day events displaying incorrectly on welcome page #663

Closed
bridgetkromhout opened this issue Oct 6, 2018 · 4 comments · Fixed by #664
Closed

single-day events displaying incorrectly on welcome page #663

bridgetkromhout opened this issue Oct 6, 2018 · 4 comments · Fixed by #664
Labels

Comments

@bridgetkromhout
Copy link
Contributor

As reported by @robscott in devopsdays/devopsdays-web#5565, single-day events are displaying incorrectly. I have a correction pending for this regression.

@bridgetkromhout
Copy link
Contributor Author

bridgetkromhout commented Oct 6, 2018

Part of the build timed out, but you can see it in action in the branch deploy that didn't time out: https://fix-dates-welcome-page--devopsdays-theme.netlify.com/events/2018-paris/welcome/

screen shot 2018-10-06 at 6 17 24 pm

contrasted with what's live in production before the fix is available: https://www.devopsdays.org/events/2018-paris/welcome/

screen shot 2018-10-06 at 6 17 04 pm

devopsdays Paris 2018
devopsdays Paris 2018

@bridgetkromhout
Copy link
Contributor Author

bridgetkromhout commented Oct 6, 2018

Likely of interest to @robscott, who reported this issue. The part controlled by the theme will be updated when this is reviewed, merged, and deployed by @mattstratton.

Please note that for your one-day event you'll probably want to edit https://github.com/devopsdays/devopsdays-web/blame/master/content/events/2018-chattanooga/welcome.md#L12-L17 to say "Date" and only use one of event_start or event_end - that's controlled by you, not by the theme, but is probably what you want to do there.

GitHub
This is the website for devopsdays.org. Contribute to devopsdays/devopsdays-web development by creating an account on GitHub.

@mattstratton
Copy link
Member

Huh. This used to work.

@bridgetkromhout
Copy link
Contributor Author

Huh. This used to work.

Right. I think this is a regression caused by the datetime cleanup work. Is there anything else you'd like done here? I'd like to get this fix into production.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants