-
Notifications
You must be signed in to change notification settings - Fork 12
Change the setting in sample new event #265
Conversation
This allows for use of the default square image as an override. Open to bikeshedding as if it should be defaulting to "true" on a new event.
Can we put the logic elsewhere? Make the config file have the setting start out empty. If not set, then use default. Prompt for the file when creating event but if it's not set, leave empty and use default. I don't think it's helpful for us to be adding settings that are basically that logic flow? |
Oh, that makes a lot of sense. If it's not set, just show the default. I honestly think that's what the code does right now anyway. Yep. Just checked. That's what it does:
I suppose it already works as designed, then. There's no need for a setting; you just HAVE to name the file that. |
Hmm. We just need to tell them that not only do they need to add that setting, but the file has to be called It seems like a weird setting to make be the filename, since that implies it can be something non-boolean. |
We can also go back to the "check if there is a |
Fine by me. Point being, if it's not actually configurable, making it a configuration setting seems off to me. |
If I recall correctly, checking in the yaml was easier than inspecting the filesystem. I'm fine with either. |
It's configureable, just not configurable as to what it is. It's default/custom :) |
Closing and moving the 🚲 🏠 to #255 |
This allows for use of the default square image as an override. Open to bikeshedding as if it should be defaulting to "true" on a new event.