-
Notifications
You must be signed in to change notification settings - Fork 12
Add display of videos and slides to program page #605
Conversation
This is still a POC - the icons used can be replaced with something different. Please consider options at http://fontawesome.io/icons/ for other choices. Signed-off-by: Matt Stratton <[email protected]>
This PR supercedes #605 |
Here's a direct link to the program preview https://deploy-preview-605--devopsdays-theme.netlify.com/events/2017-ponyville/program |
Hey sorry I was so swamped. Finally took a look at this. The icons are okay - I like the camera and I would prefer a non-powerpoint-specific one but there aren't great alternatives (which is probably what you found too). I would like it better if there were an option to toggle this on and off (personal choice - I think it makes the program page look cluttered and I would leave it off for my city if given the option) - is this just MVP and it would be okay to add that, or are you thinking you'd just prefer it always be on? |
We could make it toggleable, but I would prefer to leave it on. Adding more configuration just adds complexity - I suppose the best place is to make it a flag in the data file rather than the program file frontmatter. Right now, until devopsdays-cli is shipped, I'm putting in a freeze on any new fields in the data files so that I don't have a moving target. My thought would be to ship this as it is (not toggleable) and then put in a new issue to add the toggle feature? |
@bridgetkromhout Are you okay with deploying this without the toggle for now (so it's always-on) and we will add a toggle later (and by later I mean "pretty soon")? |
Hmm. I am against adding visual clutter that has no opt-out, because I think that could dissuade people from using the frontmatter at all (and we want them to use the frontmatter). Concrete example: devopsdays/devopsdays-web#3576 features me saying "oh, use the frontmatter - here's what it will look like" and I can sell it just as that - I don't have to include "also, you'll get a bunch of icons over on the program page". I understand we want to work in incremental improvements, but I think overshooting to "and now here's new clutter... okay now we're backing out of making it appear by default" would damage my confidence in the product, were I an end user. I am apparently ultra-conservative in product design, lol. That said, you are the web lead. You can overrule me on this. But that's my thinking. |
Gotcha. Let me hack on this and see if we can enable it easily via frontmatter on the program page, and then we will re-review. |
I believe that this works fine if you set a null/empty value, or don't set it at all. I use this on my speaker page - code is here https://github.com/mattstratton/mattstratton-web/blob/master/themes/mattstrattondotcom/layouts/speaking/list.html#L86-L91 (@bridgetkromhout, yay or nay?)
|
Compare Bear in mind I am using a newer version of FontAwesome (which we should upgrade to soon anyway) so there are some nicer icons.
There should be a way to opt out of it, I suspect you are looking for it to be opt-in. I suggest we ask the other organizers.
|
The "powerpoint" imagery doesn't cover most cases, and being specific to a file format is weird. I like the "screen" one in the pro pack, but if we don't go with that, I'd prefer "document".
Replacing the powerpoint icon with a more generic text one.
Okay, I did a few things:
Unfortunately that doesn't seem to be the case (as it's showing up for 2018-minneapolis, which definitely doesn't have anything specific set for this). I'm cool with getting this merged if we can make it either opt-out or opt-in, but "default on, and we can't turn it off" isn't awesome, since this isn't how I want my schedule page to look (this image is from the original before I changed the icon, because for some reason netlify is being weird now): |
Yeah, I don’t know what I meant by the null/empty; I’m pretty sure I can add a toggle in frontmatter on the program template to enable it (opt-in only). I’ll try that either later tonight or tomorrow morning. Netlify is trying to load some bower components because of gulp - and bower’s site is returning a 502. I should take on an effort to sunset our bower dependency and replace it with yarn, as bower is old anyway. I’ll work on that in the morning too. |
Requires the page frontmatter parameter “icons” to be set to “true” on the `program.md` file for an event for video and/or slide links to show in the progam page Signed-off-by: Matt Stratton <[email protected]>
Bower with gulp is deprecated and causing build issues Signed-off-by: Matt Stratton <[email protected]>
Bower with gulp is deprecated and causing build issues Signed-off-by: Matt Stratton <[email protected]>
I added an opt-in toggle; it will only display the video/slide links on the progarm page if I'm open for bikeshedding on the field name if there's a better idea. I also suggest we update the template in web to have this field set to "false" so it's exposed and available. |
Checked out http://deploy-preview-605--devopsdays-theme.netlify.com/events/2018-minneapolis/program and it checks out: the opt-in means it doesn't show there. Awesome!
|
This is still a POC - the icons used can be replaced with something different.
Please consider options at http://fontawesome.io/icons/ for other choices.
This only shows one link per video option or slide option.
Look at the Ponyville program in the pre-render on netlify to see what it looks like.
Fixes #600
Signed-off-by: Matt Stratton [email protected]
This change is