This repository has been archived by the owner on Jul 21, 2019. It is now read-only.
ensures speaker's multiple talks in a single event display #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance improvement in devopsdays#644 to the speaker page implicitly (and incorrectly) assumes that a speaker will give a single talk per event. Rather than using .GetPage which can return only a single page, we can change the original call to .Site.Pages and get the correct behavior with at least some of the performance improvement. This could be further improved if the program YAML included the event name, or if Hugo supported a "contains" or "startswith" operator in the where function. Fixes devopsdays#643 (comment) Replaces devopsdays-web f944fea71d071b959f715e9cdcb0ebb00f52c978
|
Thanks, @tgross! I see the update working correctly in https://deploy-preview-658--devopsdays-theme.netlify.com/events/2018-portland/speakers/heidi-waterhouse/.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance improvement in #644 to the speaker page implicitly (and incorrectly) assumes that a speaker will give a single talk per event. Rather than using
.GetPagewhich can return only a singlepage, we can change the original call to
.Site.Pagesand get the correct behavior with at least some of the performance improvement.This could be further improved if the program YAML included the event name, or if Hugo supported a "contains" or "startswith" operator in the where function.
Fixes #643 (comment)
Replaces devopsdays/devopsdays-web#5404
I've tested this locally with the content in the main site, using the specific page called out in the issue (https://www.devopsdays.org/events/2018-portland/speakers/heidi-waterhouse/)
cc @bridgetkromhout
This change is