Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to delimit event names in main header with pipes #34

Closed
mattstratton opened this issue Nov 20, 2015 · 6 comments
Closed

Need a way to delimit event names in main header with pipes #34

mattstratton opened this issue Nov 20, 2015 · 6 comments
Assignees
Milestone

Comments

@mattstratton
Copy link
Member

Have to figure out how to filter through the range of current events to determine the last one in the range, so it won't output the pipe

@mattstratton mattstratton added this to the 1.0 milestone Nov 20, 2015
@m1keil
Copy link
Contributor

m1keil commented Nov 22, 2015

sorry, not sure I understood this one.
Are we talking about Warsaw - Kiel - this?

@m1keil
Copy link
Contributor

m1keil commented Nov 22, 2015

OK, I assume it is. I've looked into it.
It seems like hugo right now really likes to work with lists but having a really bad time with maps.
In case of the data directory, everything is being read into map[filename][content].
Sadly hugo's where function only works with arrays right now, and I cannot quickly filter out the "current" events into a list, then use the same approach that they use here (basically working with array's length). We can convert events to a single event.yaml to solve this but I don't like it... (manipulating data structure to solve logical problem... no thank you)

Need to chat with them, maybe there's another creative solution with this.

m1keil added a commit that referenced this issue Nov 22, 2015
but please lets look if there's better solution
because this makes me want to poke my eyes out
@m1keil
Copy link
Contributor

m1keil commented Nov 22, 2015

See this branch for very ugly workaround

@mattstratton
Copy link
Member Author

I agree about not making the events data munged into one giant file - that causes all sorts of merge hell possibility, not to mention that the data file itself will become unwieldy. Looking at the code in https://github.com/devopsdays/devopsdays-web/tree/issue-34, it seems like a workable fix (perfection is the enemy of good, and using Scratch seems to be a common workaround in Hugo).

@mattstratton
Copy link
Member Author

Created #54 for refactor work in future enhancements, but this works for now, IMHO.

mattstratton added a commit that referenced this issue Nov 22, 2015
Fix for #34 (remove extra dash on homepage)
@m1keil
Copy link
Contributor

m1keil commented Nov 22, 2015

Agreed. I will check if there's cleaner way to handle it, since similar issues probably will arise.

yvovandoorn pushed a commit that referenced this issue May 22, 2016
but please lets look if there's better solution
because this makes me want to poke my eyes out
yvovandoorn pushed a commit that referenced this issue May 22, 2016
Fix for #34 (remove extra dash on homepage)
yvovandoorn pushed a commit that referenced this issue May 29, 2016
but please lets look if there's better solution
because this makes me want to poke my eyes out
yvovandoorn pushed a commit that referenced this issue May 29, 2016
Fix for #34 (remove extra dash on homepage)
MikeRosTX pushed a commit that referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants