Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps code adds extra strings #35

Closed
mattstratton opened this issue Nov 20, 2015 · 6 comments
Closed

Maps code adds extra strings #35

mattstratton opened this issue Nov 20, 2015 · 6 comments
Milestone

Comments

@mattstratton
Copy link
Member

See https://discuss.gohugo.io/t/cant-insert-shortcode-parameter-without-quotation-marks/1481/6

@mattstratton mattstratton added this to the 1.0 milestone Nov 20, 2015
@mattstratton
Copy link
Member Author

So apparently there is a fix that will solve this in the dev version of hugo, which we can't really use yet because of the automagic deploys using wercker :(

@mattstratton
Copy link
Member Author

Until hugo 0.15 gets released, we will need to make the coordinates for each event added "by hand" to the javascript in the maps.html partial. We should still add the coordinates into the event yaml files so that as soon as the code supports it, it will work.

@mattstratton
Copy link
Member Author

Updates from @spf13 sound as if 0.15 should be dropping pretty soon, which will give use the SafeJS feature that will solve for this.

@mattstratton
Copy link
Member Author

Hugo 0.15 is being released tomorrow :)

@mattstratton
Copy link
Member Author

Once we implement #58, we can use SafeJS to enable this.

m1keil added a commit that referenced this issue Nov 27, 2015
@m1keil m1keil mentioned this issue Nov 27, 2015
@mattstratton
Copy link
Member Author

This has been resolved.

yvovandoorn pushed a commit that referenced this issue May 22, 2016
yvovandoorn pushed a commit that referenced this issue May 29, 2016
MikeRosTX pushed a commit that referenced this issue Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants