Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ohio 2016: Starting. Supporting "false" for TBD #166

Closed
wants to merge 11 commits into from
Closed

Ohio 2016: Starting. Supporting "false" for TBD #166

wants to merge 11 commits into from

Conversation

kjenkins19
Copy link
Contributor

@kjenkins19 kjenkins19 commented May 2, 2016 •
edited
Loading

This is the initial creation of the pages for Ohio 2016.

  • Improving logic for testing if the Start Date, End Date, or CFP Date is not set (left blank) in the YML.
    ** I updated this since "isset" was being called after using the variable, making the existing check impossible to utilize.
  • Created initial data and markup for Ohio 2016.

@mattstratton
Copy link
Member

Can you pull out the "false" thing? I added a fix this morning that fits with some other uses. See #170

@mattstratton
Copy link
Member

Let me rephase - can you pull down what I just pushed earlier today, merge it in with your changes if needed? I didn't get a chance to see everything you implemented your addition in Future works well.

@kjenkins19
Copy link
Contributor Author

Will do. Thanks.

@kjenkins19
Copy link
Contributor Author

@mattstratton I've updated based on your suggestions. Thanks!

bridgetkromhout
bridgetkromhout reviewed May 2, 2016
View reviewed changes
content/events/2016-ohio/proposals.md
@@ -0,0 +1,16 @@
+++
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this file if you like. We aren't going to support showing under-review proposals.

@bridgetkromhout
Copy link
Collaborator

I pulled this branch and it didn't build locally for me. Deferring to @mattstratton.

mattstratton
mattstratton reviewed May 2, 2016
View reviewed changes
layouts/shortcodes/cfp_dates.html
@@ -2,7 +2,7 @@
{{ $event_slug := index $path 1 }}
{{ $e := (index .Page.Site.Data.events $event_slug) }}

{{ if isset $e "cfp_date_start" }}
{{ if ($e.cfp_date_start) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull this out for now as it's not building for our tests - it works correctly on our test stuff. If you want to hack at it again, let's do a separate PR for it (vs the content you're adding)

@kjenkins19 kjenkins19 closed this May 3, 2016
@kjenkins19 kjenkins19 mentioned this pull request May 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattstratton mattstratton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjenkins19 @mattstratton @bridgetkromhout