Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to remove sponsor link form "Become a XXX Sponsor!" #294

Merged
merged 11 commits into from
May 8, 2016
Merged

Ability to remove sponsor link form "Become a XXX Sponsor!" #294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a54cfe1
Change Sponsor status to closed
May 8, 2016
c475858
Add ability to remove href when sponsor_status is set to 'closed'
May 8, 2016
06a8435
Add sample to sample yaml file
May 8, 2016
6d97f46
renamed option from 'sponsor_status' to 'sponsor_link_ask'
May 8, 2016
298fb56
moved option into the appropriate place in the yaml file similar to t…
May 8, 2016
19b2cba
Change global text to something more final -- great feedback @bridget…
May 8, 2016
efcbdf8
change 'closed' to 'yes'
May 8, 2016
b973603
chane default from 'open' to 'no'
May 8, 2016
d7c8890
change 'closed' to 'no'
May 8, 2016
41d8835
Putting some quotes around the option
May 8, 2016
f209fbb
Turning off sponsors for AMS
May 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/events/2016-amsterdam.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ team: ["Harm Boertien", "Thomas Krag", "Kerim Satirli", "Arjan Wolfs", "Wilco No
organizer_email: "[email protected]" # Put your organizer email address here
proposal_email: "[email protected]" # Put your proposal email address here

sponsor_link_ask: "closed"
sponsors_accepted: "yes"
sponsors:
# gold
- id: chef
Expand Down
2 changes: 1 addition & 1 deletion themes/devopsdays-legacy/layouts/partials/event_footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h2>{{ .label }} Sponsors</h2>
{{ end }}
{{ end }}
{{ if eq $e.status "current" }}
{{ if eq $e.sponsor_link_ask "closed" }}
{{ if eq $e.sponsors_accepted "closed" }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be easier to understand if instead of "closed"/"open" it's "yes"/"no" (as seen in the yaml file above).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. You're right. I missed that in my branch.

On Sunday, 8 May 2016, Bridget Kromhout [email protected] wrote:

In themes/devopsdays-legacy/layouts/partials/event_footer.html
#294 (comment)
:

@@ -19,7 +19,7 @@
{{ end }}
{{ end }}
{{ if eq $e.status "current" }}

  •  {{ if eq $e.sponsor_link_ask "closed" }}

  •  {{ if eq $e.sponsors_accepted "closed" }}

I think this will be easier to understand if instead of "closed"/"open"
it's "yes"/"no" (as seen in the yaml file above).

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/devopsdays/devopsdays-web/pull/294/files/298fb56f8b9e7ebfa4a7daf67db5b9017f0f5228..19b2cba09de8fbaf11a50fb0c68cca5594eb5ac3#r62431741

Yvo van Doorn — Manager, Technical Services (EMEA)

+31 6 38 74 07 46 <+316740746> – [email protected] – *my: *Linkedin
http://www.linkedin.com/in/yvovandoorn/ Twitter
https://twitter.com/yvov

CHEF

CHEF.IO http://www.chef.io/

TM

chef.io http://www.chef.io/ Blog http://www.chef.io/blog/ Facebook
https://www.facebook.com/getchefdotcom Twitter
https://twitter.com/chef Youtube https://www.youtube.com/getchef

<div class = "sponsor-cta">
<br>
</div>
Expand Down
2 changes: 1 addition & 1 deletion yyyy-city.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ sponsors:
- id: arresteddevops
level: community

sponsor_link_ask : open # Whether you want "Become a XXX Sponsor!" link
sponsors_accepted : open # Whether you want "Become a XXX Sponsor!" link
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're quoting most strings in this file, I think? (Also, let's make it "yes".)

sponsor_levels: # In this section, list the level of sponsorships and the label to use.
- id: gold
label: Gold
Expand Down