-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new thoughtworks products logo #503
Conversation
If I merge this, it will be effective now for all devopsdays sites using this logo. This will force a retroactive change for events that are already past. I'd prefer a PR that moves $ grep -r thoughtworks-products data/events/* I really like the simplicity of "every new event can just use thoughtworks-product because it's assumed current" but we should solve the wider problem too in this case. (Didn't have to worry about this for the solidfire->netapp switch because it only affected two events that were still in the future.) Flagging @mattstratton for insights. |
Should the decision about "use the one which was accurate at the time" vs "change them all for consistency" be decided by the DevOpsDays events or the organization represented by the logo? For this specific case, it's my desire (or more accurately my marketing team's desire) as the logo owner to have them all change, as we've been told many times the previous logo is confusing. |
IMHO if the sponsor is the one who wants them all to change, then it's fine to change retroactively. Pending the following points:
The tricky part is that it does change a bunch of sites out from underneath them, probably without their awareness. |
I guess the question is - if not handled this way, would ThoughtWorks be asking all the existing events to update the logo anyway? |
In this specific case ThoughtWorks would ask for the change, because people think we have a product called "go snap", and the bad logo was created specifically for the square devopsdays requirement. That said, the desire doesn't necessarily make it a reasonable request in the webby world of needing multiple changes. My thought on creating the PR was that with Hugo it's actually easier to do a bulk change than only future looking. I hadn't considered the fact that I would be changing finished events without talking to those cities. I think I would have done it the same way if a company other than my own was making the request. If changing another city's event is the primary concern I'm not sure it shouldn't mean that getting buy in from future cities is needed as well. That seems pretty hard. |
I've sent email to the organizer's list for the past events to see if anyone objects. |
I don't like the idea of rewriting history for completed events. For good or for ill, that was the logo that was in use at the time of the event. Reconning it is inaccurate. I am fine with a sponsor wanting to change all logos on all events that haven't happened yet. That doesn't require consent from every affected city (though probably they'll want to know anyhow, for purposes of updating banners and the like). So in this case, I'm fine with doing the work if @kmugrage doesn't have time, and I mostly want @mattstratton's sanity check on whether my proposed name-spacing is the best way to preserve history while also making the "default" easy to use. I object to any sponsor getting the green light to rewrite history. |
Ah, ok, didn't understand that you didn't want it changed regardless. I can do the work. Thanks |
I believe this now preserves all past events who used that logo. The more I think about it the more I agree that rewriting history wasn't the greatest idea. Even if it was easier :) |
Thanks, @kmugrage! |
No description provided.