Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comment-preview): can't post a comment and don't query notification messages if user doesn't signin #553

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

devrsi0n
Copy link
Owner

@devrsi0n devrsi0n commented Dec 8, 2022

Description

Fixes a dozen of issues:

  • Can't post a comment in comment widget preview on home page
  • Shouldn't query notification messages in comment widget preview

Added a new feature:

  • show popover if user can't create a project, e.g. system maintenance mode, anonymous user or reach maximum project number

image

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

  • Unit tests and integration tests passed
  • No reduction in test coverage
  • Documentation is up to date (if appropriate)
  • Related issues linked using fixes #number

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

⚠️ No Changeset found

Latest commit: 7426e22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chirpy ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 2:26PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Coverage report for ./apps/main

St.
Category Percentage Covered / Total
🔴 Statements 8.73% 40/458
🔴 Branches 10.23% 9/88
🔴 Functions 4.1% 5/122
🔴 Lines 9.25% 38/411

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 7426e22

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Coverage report for ./packages/ui

St.
Category Percentage Covered / Total
🔴 Statements
52.85% (+0.13% 🔼)
2373/4490
🔴 Branches
26.89% (-0.1% 🔻)
441/1640
🔴 Functions
36.41% (+0.21% 🔼)
461/1266
🔴 Lines
52.95% (+0.14% 🔼)
2256/4261
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / create-project-button.tsx
78.57% 36.36% 100% 78.57%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / user.ts
85.71% (-14.29% 🔻)
100%
66.67% (-33.33% 🔻)
100%
🟡
... / index.tsx
64.29% (-1.23% 🔻)
57.14% (+3.3% 🔼)
40%
64.29% (-1.23% 🔻)
🟢
... / notification-hub.tsx
92.31% (+3.85% 🔼)
84.62% (-6.29% 🔻)
100%
92% (+4% 🔼)
🔴
... / comment-widget-preview.tsx
34.55%
10% (-8.18% 🔻)
25% 35.85%

Test suite run success

50 tests passing in 32 suites.

Report generated by 🧪jest coverage report action from 7426e22

@relativeci
Copy link

relativeci bot commented Dec 9, 2022

Job #1209: Bundle Size — 2.02MiB (0%).

1510937(current) vs 1510937 main#1208(baseline)

Metrics (1 change)
                 Current
Job #1209
     Baseline
Job #1208
Initial JS 1.39MiB 1.39MiB
Initial CSS 90.41KiB 90.41KiB
Cache Invalidation 0% 24.42%
Chunks 50 50
Assets 57 57
Modules 1045 1045
Duplicate Modules 182 182
Duplicate Code 4.83% 4.83%
Packages 88 88
Duplicate Packages 0 0
Total size by type (no changes)
                 Current
Job #1209
     Baseline
Job #1208
CSS 90.41KiB 90.41KiB
Fonts 0B 0B
HTML 0B 0B
IMG 0B 0B
JS 1.92MiB 1.92MiB
Media 0B 0B
Other 11.53KiB 11.53KiB

View job #1209 reportView prod branch activity

@cypress
Copy link

cypress bot commented Dec 9, 2022



Test summary

4 2 0 1Flakiness 0


Run details

Project chirpy
Status Failed
Commit 7426e22
Started Dec 9, 2022 2:27 PM
Ended Dec 9, 2022 2:30 PM
Duration 02:20 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


Failures

home/header.spec.ts Failed
1 Header > should show user menu
dashboard/project.spec.ts Failed
1 Project > should show integration doc

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@devrsi0n devrsi0n merged commit 1510937 into main Dec 9, 2022
@devrsi0n devrsi0n deleted the fix/anonymous-user-cannot-create-a-project branch December 9, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant