Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support Topic Whitelisting #90

Open
deepbrook opened this issue Feb 11, 2022 · 1 comment · Fixed by joschi/kafka-gitops#74
Open

Feature Request: Support Topic Whitelisting #90

deepbrook opened this issue Feb 11, 2022 · 1 comment · Fixed by joschi/kafka-gitops#74

Comments

@deepbrook
Copy link

Currently, only topic black-listing is supported, which works great for centralized ACL management.

However, it makes decentralized topic management difficult. We have multiple teams managing their own kafka topics on the same cluster. They currently need to blacklist each of the other teams' prefix. Whenever we onboard new teams, the blacklist needs updating - a very error-prone process, because, you know, people.

How should this work?

It would be an exact inversion of the current blacklisting:

settings:
    whitelist:
      prefixed: 
        - only.my.topics.

..would only manage topics with the above prefix - this also means that any topics declared in the state file NOT matching this prefix are ignored (or perhaps throw an error).

The two mechanisms would be expected to be mutually exclusive.

settings:
    whitelist: {...}
    blacklist: {...}  # Specifying both types raises a validation error
@joschi
Copy link

joschi commented Nov 11, 2022

FYI: I've added this functionality to my fork of kafka-gitops.

➡️ https://github.com/joschi/kafka-gitops/releases/tag/0.3.0

Please note the renaming of blacklist to exclude and the corresponding include setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants