connectors/oidc: truely ignore "email_verified" claim if configured that way #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/post-1448/fix-1455/restore-error-semantics
branch
from
d0f53fd
to
221a2a8
Compare
|
Looks like I'll look into travis first. Likely ditching support for golang 1.10. 🤔 |
pbochynski
approved these changes
May 28, 2019
|
@pbochynski thank you so much for verifying. I'll merge this when I've dealt with the travis issue... |
|
#1457 ✔️ |
…hat way Fixes dexidp#1455, I hope. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/post-1448/fix-1455/restore-error-semantics
branch
from
221a2a8
to
4e8cbf0
Compare
|
@JoelSpeed @ericchiang This is rather trivial, and @pbochynski has been so kind to review it -- so, I'll pull the admin string to still merge this pull request. LMK if you think I shouldn't have. 😉 |
|
Looks ok to me :) |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…store-error-semantics connectors/oidc: truely ignore "email_verified" claim if configured that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1455, I hope.