Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci linter #1603

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Add golangci linter #1603

merged 2 commits into from
Dec 18, 2019

Conversation

sagikazarmark
Copy link
Member

@sagikazarmark sagikazarmark commented Dec 18, 2019 •
edited
Loading

Replaces golint, fmt, vet with GolangCI lint.

@sagikazarmark sagikazarmark changed the title Add golangci linter WIP: Add golangci linter Dec 18, 2019
@sagikazarmark sagikazarmark changed the title WIP: Add golangci linter Add golangci linter Dec 18, 2019
bonifaido
bonifaido approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sagikazarmark sagikazarmark merged commit e0f927c into master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagikazarmark @bonifaido