Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework - add support for Resource Owner Password Credentials Grant #1621

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

xtremerui
Copy link

As per comment #1163 (comment), this PR from ConcourseCI team is a rework of #1163 since the original PR is outdated and its author allowed us to continue his work.

cc @pivotal-jwinters

@bonifaido thanks!

Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR was reviewed already, and I haven't found anything suspicious in this rebased version, so it LGTM!

@vito
Copy link
Contributor

vito commented Feb 19, 2020

Hi, just checking in - any chance this could be merged? Just hoping to gradually shrink the amount of PRs we have open (listed in concourse/concourse#4983 (comment)) so we can get off our fork. Thanks if so! 🙂

@bonifaido bonifaido merged commit 1160649 into dexidp:master Feb 20, 2020
@bonifaido
Copy link
Member

Of, course, sorry for being late on this one.

@speculatrix
Copy link

How do I make use of this to make "fly -t xx login" work with an ldap username/password?

@roDew
Copy link

roDew commented Sep 9, 2020

I'm interested in the same too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants