-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework - add support for Resource Owner Password Credentials Grant #1621
Conversation
7f2b943
to
1ca4e62
Compare
1ca4e62
to
0f9a74f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR was reviewed already, and I haven't found anything suspicious in this rebased version, so it LGTM!
Hi, just checking in - any chance this could be merged? Just hoping to gradually shrink the amount of PRs we have open (listed in concourse/concourse#4983 (comment)) so we can get off our fork. Thanks if so! 🙂 |
Of, course, sorry for being late on this one. |
How do I make use of this to make "fly -t xx login" work with an ldap username/password? |
I'm interested in the same too... |
As per comment #1163 (comment), this PR from ConcourseCI team is a rework of #1163 since the original PR is outdated and its author allowed us to continue his work.
cc @pivotal-jwinters
@bonifaido thanks!