-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of returned groups via authproxy connector #2371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @seuf. Thank you for your intention to work on this feature.
- I left a comment. We need to figure out the right approach before moving further.
- Would you mind adding the note that authproxy now supports groups to the README.md?
Line 78 in 716eef8
| [AuthProxy](https://dexidp.io/docs/connectors/authproxy/) | no | no | no | alpha | Authentication proxies such as Apache2 mod_auth, etc. |
6d6f64a
to
d085bc5
Compare
Hi @nabokihms I've updated this PR. You can now configure both I've tested it on my argocd dex deployment, and it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for your work. There are some comments left. Please look through them when you have time.
And one more thing. I would like you to also make changes to the module documentation to inform users about the feature you have made.
https://github.com/dexidp/website/blob/main/content/docs/connectors/authproxy.md
Via HTTP Header if present and with manually configured staticGroups in authproxy connector Signed-off-by: seuf <[email protected]>
d085bc5
to
4ee9658
Compare
Hi @nabokihms I've applied the changes you suggested. PR for the website documentation : |
Hi @nabokihms Do you have time this week to review this again ? |
Overview
Added
groupHeader
andgroups
configuration for authproxy connector.Example :
What this PR does / why we need it
This allow users to configure argocd dex to use authproxy connector and specify the users default group and the HTTP header to read to get the group.