Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric user ID support for oauth connector #2483

Merged
merged 2 commits into from
May 11, 2022

Conversation

tsl0922
Copy link
Contributor

@tsl0922 tsl0922 commented Apr 21, 2022

Signed-off-by: Shuanglei Tao [email protected]

Overview

What this PR does / why we need it

Add numeric user ID support for oauth connector

Special notes for your reviewer

Does this PR introduce a user-facing change?

Add numeric user ID support for oauth connector

Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for opening this PR. I have only one thing to discuss before we can merge this.

connector/oauth/oauth.go Outdated Show resolved Hide resolved
@nabokihms
Copy link
Member

@tsl0922, the linter throws an error. Could you please check it so we can merge this PR?

Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@nabokihms
Copy link
Member

Docker build is not working, but it looks like a problem on our side.

@nabokihms nabokihms merged commit 997ec94 into dexidp:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants