Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update response_types_supported to allow multiple-valued response type combinations #2521

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

Cedric-Magnan
Copy link
Contributor

@Cedric-Magnan Cedric-Magnan commented May 18, 2022

Overview

DEX can support multiple-valued response type combinations (spec) but doesn't display it on the server endpoint :
https://<idp_url>/.well-known/openid-configuration

This PR fixes this issue.

What this PR does / why we need it

Some applications will check the response_types_supported retrieved from the following URL : https://<idp_url>/.well-known/openid-configuration before performing any flow.

DEX servers will only display the following supported response types :

"response_types_supported": [
  "code",
  "id_token",
  "token"
]

Since DEX can support multiple-valued response type combinations, this field should display :

"response_types_supported": [
  "code",
  "id_token",
  "token",
  "code token",
  "code id_token",
  "token id_token",
  "code token id_token"
]

Closes #1449

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

@Cedric-Magnan Cedric-Magnan changed the title Update response_types_supported to allow multiple-valued response type combinations feat: Update response_types_supported to allow multiple-valued response type combinations May 18, 2022
@Cedric-Magnan Cedric-Magnan marked this pull request as ready for review May 18, 2022 14:12
@nabokihms nabokihms self-requested a review May 18, 2022 14:14
@sagikazarmark sagikazarmark modified the milestones: v2.32.0, v2.33.0 May 26, 2022
@nabokihms
Copy link
Member

@Cedric-Magnan, hello, and thank you for opening this PR. It is a long-term issue, and we'd like to fix this!
Reviewing this PR is on my list (I hope I will get to it soon).

@nabokihms nabokihms modified the milestones: v2.33.0, v2.34.0 Jul 28, 2022
@nabokihms nabokihms modified the milestones: v2.34.0, v2.35.0 Sep 16, 2022
@sagikazarmark sagikazarmark modified the milestones: v2.35.0, v2.36.0 Sep 29, 2022
@sagikazarmark
Copy link
Member

@Cedric-Magnan apologies for the delay on reviewing this PR. Would you mind rebasing it though before we proceed? Thanks!

@Cedric-Magnan
Copy link
Contributor Author

@Cedric-Magnan apologies for the delay on reviewing this PR. Would you mind rebasing it though before we proceed? Thanks!

No problem @sagikazarmark, I've now rebased my fork from the latest commits on master

@nabokihms nabokihms modified the milestones: v2.36.0, v2.37.0 Mar 11, 2023
@sagikazarmark
Copy link
Member

Looks good to me, but CI isn't running for some reason. Can you do one more rebase please @Cedric-Magnan ? Thanks!

Cedric-Magnan and others added 3 commits May 30, 2023 09:47
Signed-off-by: Cedric-Magnan <[email protected]>
Signed-off-by: Cedric-Magnan <[email protected]>
Signed-off-by: Cedric-Magnan <[email protected]>
@Cedric-Magnan
Copy link
Contributor Author

Looks good to me, but CI isn't running for some reason. Can you do one more rebase please @Cedric-Magnan ? Thanks!

@sagikazarmark, I've rebased with the latest commit from master, the workflows can now be approved !

@sagikazarmark sagikazarmark modified the milestones: v2.37.0, v2.38.0 Jul 22, 2023
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sagikazarmark sagikazarmark merged commit 295b0ac into dexidp:master Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response_types_supported looks incorrect
3 participants