-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update response_types_supported to allow multiple-valued response type combinations #2521
Conversation
@Cedric-Magnan, hello, and thank you for opening this PR. It is a long-term issue, and we'd like to fix this! |
@Cedric-Magnan apologies for the delay on reviewing this PR. Would you mind rebasing it though before we proceed? Thanks! |
3872736
to
de5d836
Compare
No problem @sagikazarmark, I've now rebased my fork from the latest commits on master |
Looks good to me, but CI isn't running for some reason. Can you do one more rebase please @Cedric-Magnan ? Thanks! |
Signed-off-by: Cedric-Magnan <[email protected]>
Signed-off-by: Cedric-Magnan <[email protected]>
Signed-off-by: Cedric-Magnan <[email protected]>
@sagikazarmark, I've rebased with the latest commit from master, the workflows can now be approved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Overview
DEX can support multiple-valued response type combinations (spec) but doesn't display it on the server endpoint :
https://<idp_url>/.well-known/openid-configuration
This PR fixes this issue.
What this PR does / why we need it
Some applications will check the
response_types_supported
retrieved from the following URL : https://<idp_url>/.well-known/openid-configuration before performing any flow.DEX servers will only display the following supported response types :
Since DEX can support multiple-valued response type combinations, this field should display :
Closes #1449
Special notes for your reviewer
Does this PR introduce a user-facing change?