Add context to storage's Create endpoints #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PumpkinSeed <[email protected]>
Signed-off-by: PumpkinSeed <[email protected]>
Signed-off-by: PumpkinSeed <[email protected]>
Signed-off-by: PumpkinSeed <[email protected]>
PumpkinSeed
force-pushed
the
I2132-context-into-storage
branch
from
dbe5725
to
e91b39f
Compare
nabokihms
approved these changes
May 18, 2023
There was a problem hiding this comment.
Thanks for this one, @PumpkinSeed. We are about to release the new version of Dex v2.37, and this change is only a part of the big improvement. If you don't mind, I'd like to mark this PR for the upcoming release v2.38.
|
@PumpkinSeed, sorry for the long delay. Could you please rebase the branch so we can merge it? |
sagikazarmark
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduce the context for the storage interface's Create endpoints.
What this PR does / why we need it
Resolves part of the #2132
Special notes for your reviewer
NONE
Does this PR introduce a user-facing change?
NONE