Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector/microsoft): support custom api and graph URLs #3084

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

sagikazarmark
Copy link
Member

Overview

Support custom API and graph URLs in Microsoft/Azure connector.

From #2459

This change makes the Azure endpoints configurable. For most users, the default
https://login.microsoftonline.com/ and https://graph.microsoft.com/ values
will remain the correct choice, but this allows users of Azure in special
regions, such as Government Cloud Services for export-controlled workloads,
to use the Microsoft connector to get group membership.

What this PR does / why we need it

Fixes #2457
Fixes #2459

Special notes for your reviewer

I was not able to test this change as I don't have access to such environments.

Does this PR introduce a user-facing change?

Support custom api and graph URLs in Microsoft/Azure connector

@dsetlock
Copy link

dsetlock commented Oct 3, 2023

Hoping to bump this for reviewing approver

@nabokihms nabokihms merged commit b772ed5 into master Oct 24, 2023
12 checks passed
@nabokihms nabokihms deleted the azure-custom-urls branch October 24, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dex can not authenticate against USGovernment Azure via OIDC.
3 participants