Fix etcd device requests #3119
Merged
Fix etcd device requests #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MM53 <[email protected]>
…nput Signed-off-by: MM53 <[email protected]>
nabokihms
approved these changes
Sep 26, 2023
Signed-off-by: MM53 <[email protected]>
nabokihms
approved these changes
Oct 19, 2023
|
@MM53 there is a problem with the test. Would you mind fixing it? |
Signed-off-by: MM53 <[email protected]>
auto-merge was automatically disabled
October 20, 2023 06:47
Head branch was pushed to by a user without write access
MM53
force-pushed
the
fix-etcd-device-codes
branch
2 times, most recently
from
8b9b31d
to
8e35c61
Compare
|
There is an issue with postgres showing "UCT" as default instead of "UTC". I set it to "UTC" for the tests. |
nabokihms
approved these changes
Oct 20, 2023
mdpradeep
pushed a commit
to mdpradeep/dex
that referenced
this pull request
Oct 20, 2023
Signed-off-by: MM53 <[email protected]> Signed-off-by: Pradeep Mudlapur <[email protected]>
jtfrey
pushed a commit
to jtfrey/dex
that referenced
this pull request
Oct 20, 2023
Signed-off-by: MM53 <[email protected]> Signed-off-by: Jeffrey Frey <[email protected]>
mdpradeep
added a commit
to mdpradeep/dex
that referenced
this pull request
Oct 20, 2023
This reverts commit dddbe19.
orange-hbenmabrouk
pushed a commit
to orange-hbenmabrouk/dex
that referenced
this pull request
Oct 23, 2023
Signed-off-by: MM53 <[email protected]>
orange-hbenmabrouk
pushed a commit
to orange-hbenmabrouk/dex
that referenced
this pull request
Oct 23, 2023
Signed-off-by: MM53 <[email protected]> Signed-off-by: Houssem Ben Mabrouk <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a missing type conversion while reading device requests from etcd storage and add a check for this case to the storage conformance tests.
What this PR does / why we need it
This PR resolves the bug described in #3118
Special notes for your reviewer
Does this PR introduce a user-facing change?