Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC connector: Allow specifying empty prompt type #3373

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

nabokihms
Copy link
Member

Overview

Enhanced the OIDC connector to allow specifying an empty promptType parameter. Previously, the default behavior always appended 'consent' if promptType was not specified. This adjustment was necessary due to variations in default behaviors across certain Identity Providers (IDPs).

What this PR does / why we need it

https://cloud-native.slack.com/archives/C01HF2G1R34/p1708423095710099

Special notes for your reviewer

Enhanced the OIDC connector to allow specifying an empty promptType parameter. Previously, the default behavior always appended 'consent' if promptType was not specified. This adjustment was necessary due to variations in default behaviors across certain Identity Providers (IDPs).

Signed-off-by: m.nabokikh <[email protected]>
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

connector/oidc/oidc.go Show resolved Hide resolved
@nabokihms nabokihms merged commit e5dce3d into dexidp:master Mar 12, 2024
9 checks passed
@nabokihms nabokihms deleted the empty-prompt-type branch March 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants