Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add acr_values field description into the docs #110

Merged
merged 1 commit into from
May 18, 2022
Merged

docs: Add acr_values field description into the docs #110

merged 1 commit into from
May 18, 2022

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Feb 22, 2022

Hi,

This PR adds the description for the new config field acrValues

the original issue is here -> dexidp/dex#2417

Signed-off-by: Engin Diri [email protected]

@dirien dirien mentioned this pull request Feb 22, 2022
Merged
nate-double-u
nate-double-u approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions inline, but otherwise, /lgtm

content/docs/connectors/oidc.md Outdated Show resolved Hide resolved
content/docs/connectors/oidc.md Outdated Show resolved Hide resolved
@dirien
Copy link
Contributor Author

dirien commented Mar 8, 2022

Hi @nate-double-u,

thanks for the suggestions. I updated the PR with your feedback.

@dirien
Copy link
Contributor Author

dirien commented Apr 7, 2022

Smol ping for this PR :)

nabokihms
nabokihms approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dirien! Nice work.

@nabokihms nabokihms merged commit 3f95d2e into dexidp:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirien @nate-double-u @nabokihms