Transaction.abort does not rollback changes #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that changes don't get written to disk if the transaction is aborted
|
Thanks! I'll look into it soon! |
dfahlander
added a commit
that referenced
this pull request
Jun 5, 2021
dfahlander
added a commit
that referenced
this pull request
Jun 6, 2021
|
We should have had this test long time before. |
|
Thanks for looking into it so fast 😅 |
|
It was important to fix, and a perfect repro. I tried your repro on previous version and the bug has been there for ages. I'm a bit surprised no one has found it earlier but maybe people have just thrown an error instead to work around it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written a test to demonstrate. The documentation here states that abort
// Will discard all changes, but it doesn't seem to for me. I ran this is chrome.