Sets the unique flag for primKey to true #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although uniqueness is implied for the primary key, having this flag set to false can cause confusion.
|
We just need a unit test for it before merging it - somewhere in tests-open.js. We should verify as discussed in #1842 that if we create a database (providing a schema) and then close it and reopen it dynamically, the primary key is marked as unique. |
|
Good that I needed to add the tests, cause I discovered somewhere else that needed to be changed. If one didn't include an Hope it's good now. I know it's simple stuff for you fellas with strong PR-fu, but I'm kinda excited about my first PR in a very long time! |
|
Very nice test! This PR was really well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although uniqueness is implied for the primary key, having this flag set to false can cause confusion. As discussed in #1842.