Improve debugging experience #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dfahlander
commented
Jan 22, 2024
dfahlander
commented
- Use Chrome's Async Task Tagging API to track failing operations down to the app code that initiated the operation.
- Fail fast on table.get(undefined)
- Remove old "long stacks" support that was tailored for older browsers and have no gain anymore.
It's a common pitfall to do db.someTable.get(someVariable) without checking that someVariable isn't null. This is a common pitfall and in the case the call to Table.get() is the initial db call that the application makes, the call stack will be totally unreadable because: 1. Table.get() will first asynchronically auto-open the database. 2. Whe DB is finally opened it will fail deep inside DBCore leaving the user with an unreadable call stack. See #1806 (comment)
…k() instead. We used to have own special support for long async stacks to simplify debugging. However, now all browsers already have long async stacks supported in devtools. This commit removes all special code that deals with long stack support. It also introduces the usage of Chrome's Async Stack Tagging API (console.createTask()) that makes it easier to follow console traces on exceptions and find the application code that initiated the operation. Also, when Dexie.debug is true, we trace all errors from dexie operations with the help of async stack tagging, hopefully making it easier for app developers to find issues in app code. See #1806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.