Download leaderboard scores in parallel #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiya, first of all, I'm loving this project, one of the coolest things I've seen! I noticed that loading the leaderboard using the plugin is really slow on my computer (although that might just be my slow internet speeds talking). This is because we are sequentially downloading the address and score for each player, instead of downloading them all at the same time. This will get worse as more and more people join the colossus. This PR uses [`Promise.all()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/all) to download all scores at the same time, greatly speeding it up. (By the way, you can enable the ESLint rule [`no-await-in-loop`](https://eslint.org/docs/rules/no-await-in-loop) to check for places where you have an `await` in a loop, when you might be able to use `Promise.all()`)
scotato
pushed a commit
that referenced
this pull request
Oct 4, 2021
|
Fixed merge conflict, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya, first of all, I'm loving this project, one of the coolest things I've seen!
I noticed that loading the leaderboard using the plugin is really slow on my computer (although that might just be my slow internet speeds talking).
This is because we are sequentially downloading the address and score for each player, instead of downloading them all at the same time. This will get worse as more and more people join the colossus.
This PR uses
Promise.all()to download all scores at the same time, greatly speeding it up.(By the way, you can enable the ESLint rule
no-await-in-loopto check for places where you have anawaitin a loop, when you might be able to usePromise.all())