Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rename proc macro to take any string #522

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

chenyan-dfinity
Copy link
Contributor

Fix #521

Copy link

Benchmark for d72fc5d

Click to view benchmark
Test Base PR %
Blob/&str 635.6±94.37µs 647.2±100.80µs +1.83%
Blob/ByteBuf 358.1±92.36µs 347.4±93.38µs -2.99%
Blob/Bytes 406.9±76.41µs 406.8±78.07µs -0.02%
Blob/String 646.0±245.52µs 655.2±261.65µs +1.42%
Collections/vec (text, nat) 49.5±0.69ms 49.8±1.00ms +0.61%
Collections/vec int 23.4±0.12ms 23.9±0.09ms +2.14%
Collections/vec int64 15.7±0.06ms 16.0±0.11ms +1.91%
Collections/vec nat8 11.7±0.03ms 11.7±0.04ms 0.00%
option list/1024 955.6±10.59µs 940.2±5.27µs -1.61%
profiles/1024 1824.7±84.21µs 1795.6±14.33µs -1.59%
variant list/1024 801.1±8.62µs 793.8±7.30µs -0.91%

Copy link

Benchmark for c34d5f4

Click to view benchmark
Test Base PR %
Blob/&str 636.1±101.72µs 612.0±90.06µs -3.79%
Blob/ByteBuf 361.0±93.65µs 355.7±97.06µs -1.47%
Blob/Bytes 362.6±59.20µs 396.5±64.39µs +9.35%
Blob/String 335.5±140.03µs 333.7±137.80µs -0.54%
Collections/vec (text, nat) 49.4±0.57ms 49.6±0.75ms +0.40%
Collections/vec int 24.3±0.10ms 23.5±0.13ms -3.29%
Collections/vec int64 15.0±0.04ms 15.8±0.13ms +5.33%
Collections/vec nat8 11.1±0.07ms 11.2±0.09ms +0.90%
option list/1024 967.7±6.17µs 947.0±89.72µs -2.14%
profiles/1024 1784.1±28.47µs 1777.1±16.27µs -0.39%
variant list/1024 802.7±8.78µs 805.0±8.88µs +0.29%

@chenyan-dfinity chenyan-dfinity merged commit 8f96d79 into master Feb 14, 2024
5 checks passed
@chenyan-dfinity chenyan-dfinity deleted the fix-rename branch February 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error by rename arg when using CandidType
2 participants