[Spec] Relax LEB128 decoding #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
approved these changes
Aug 13, 2020
|
I'll have to update http://hackage.haskell.org/package/leb128-cereal and the Motoko implemenation, but that’s fine of course. @chenyan-dfinity care to update the spec tests together with this PR? |
|
Why did we not bump the Candid version with this PR? |
|
I was going to bump the version here #88. The change is documented in the Changelog.md already. |
mergify bot
pushed a commit
to dfinity/motoko
that referenced
this pull request
Sep 2, 2020
Follow up with dfinity/candid#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #73 (comment), LEB128 spec allows redundant bytes, and all existing libraries on LEB128 decodes redundant bytes properly. Removing the restriction encourages code reuse and an easier implementation.