System API for threshold ECDSA #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninegua
force-pushed
the
paul/CON-742-tecdsa-system-api
branch
from
77a4932
to
3faba31
Compare
ninegua
force-pushed
the
paul/CON-742-tecdsa-system-api
branch
from
3faba31
to
ebf0905
Compare
|
Points for discussion:
These can be added later by adding optional fields to the input. It will be backward compatible as long as the new fields have sensible defaults.
At the moment all errors are delivered through reject messages instead of returning a variant type like
|
manudrijvers
approved these changes
Feb 7, 2022
fspreiss
reviewed
Feb 8, 2022
There was a problem hiding this comment.
Thanks a lot @ninegua! I left some suggestions and nits, but otherwise it looks good.
Co-authored-by: Andrea Cerulli <[email protected]>
randombit
reviewed
Mar 3, 2022
ninegua
force-pushed
the
paul/CON-742-tecdsa-system-api
branch
from
ef389c4
to
aa19fc0
Compare
ninegua
force-pushed
the
paul/CON-742-tecdsa-system-api
branch
from
07d1bd5
to
d7b49e2
Compare
andreacerulli
approved these changes
Apr 7, 2022
Dfinity-Bjoern
approved these changes
Apr 8, 2022
jwiegley
approved these changes
Apr 8, 2022
|
Did we intentionally switch to non-squash merges now, or is that simply not discussed yet? (I'd be in favor of re-enabling mergify; automatic squash merge with PR-description-as-commit-message seems to be the simplest nicest option.) |
dfinity-bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Apr 21, 2022
EXC-1066: Enhance ECDSA key id type Change the type of the ECDSA keys from a string to a struct consisting of the curve (an enum) and the name (a string). Per the spec dfinity/interface-spec#6 (comment) See merge request dfinity-lab/public/ic!4344
basvandijk
pushed a commit
to dfinity/ic-hs
that referenced
this pull request
May 30, 2022
This PR Implements a corresponding part of the IC spec: dfinity/interface-spec#6 It also splits up `IC.Test.Agent` and `IC.Test.Spec` to reduce the excessive memory consumption of compiling those modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propose two new system APIs for the upcoming threshold ECDSA feature in the management canister.