-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings are not reported unless there are also errors #440
Labels
Bug
Something isn't working
Comments
I might have messed this up in the latest refactoring of the pipeline. Will clean up once back from my vacation. |
dfinity-bot
added a commit
that referenced
this issue
Dec 8, 2022
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@d2f20b7a...822e35d4](dfinity/motoko-base@d2f20b7...822e35d) * [`eadf03d6`](dfinity/motoko-base@eadf03d) Motoko 0.7.4 * [`1398f4fc`](dfinity/motoko-base@1398f4f) chore: applies autoformatting to all motoko files ([dfinity/motoko-base#441](https://togithub.com/dfinity/motoko-base/issues/441)) * [`fec0f522`](dfinity/motoko-base@fec0f52) Update Array.mo Summary ([dfinity/motoko-base#440](https://togithub.com/dfinity/motoko-base/issues/440))
mergify bot
pushed a commit
that referenced
this issue
Dec 8, 2022
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@d2f20b7a...822e35d4](dfinity/motoko-base@d2f20b7...822e35d) * [`eadf03d6`](dfinity/motoko-base@eadf03d) Motoko 0.7.4 * [`1398f4fc`](dfinity/motoko-base@1398f4f) chore: applies autoformatting to all motoko files ([dfinity/motoko-base#441](https://togithub.com/dfinity/motoko-base/issues/441)) * [`fec0f522`](dfinity/motoko-base@fec0f52) Update Array.mo Summary ([dfinity/motoko-base#440](https://togithub.com/dfinity/motoko-base/issues/440))
dfinity-bot
added a commit
that referenced
this issue
Oct 8, 2023
## Changelog for musl-wasi: Branch: main Commits: [WebAssembly/wasi-libc@ec4566be...4db5398e](WebAssembly/wasi-libc@ec4566b...4db5398) * [`ce2f157d`](WebAssembly/wasi-libc@ce2f157) Update thread id validation returned by `__wasi_thread_spawn` ([WebAssembly/wasi-libc#435](https://togithub.com/WebAssembly/wasi-libc/issues/435)) * [`7b4705f1`](WebAssembly/wasi-libc@7b4705f) Fix typo in signal.c error messages ([WebAssembly/wasi-libc#437](https://togithub.com/WebAssembly/wasi-libc/issues/437)) * [`d4dae896`](WebAssembly/wasi-libc@d4dae89) add shared library support ([WebAssembly/wasi-libc#429](https://togithub.com/WebAssembly/wasi-libc/issues/429)) * [`6248a00c`](WebAssembly/wasi-libc@6248a00) Adjust Makefile for LLVM trunk (18) as of 2023-10-03 ([WebAssembly/wasi-libc#438](https://togithub.com/WebAssembly/wasi-libc/issues/438)) * [`4db5398e`](WebAssembly/wasi-libc@4db5398) remove `-nostdlib` from libc.so link command ([WebAssembly/wasi-libc#440](https://togithub.com/WebAssembly/wasi-libc/issues/440))
dfinity-bot
added a commit
that referenced
this issue
Oct 9, 2023
## Changelog for musl-wasi: Branch: main Commits: [WebAssembly/wasi-libc@ec4566be...4db5398e](WebAssembly/wasi-libc@ec4566b...4db5398) * [`ce2f157d`](WebAssembly/wasi-libc@ce2f157) Update thread id validation returned by `__wasi_thread_spawn` ([WebAssembly/wasi-libc#435](https://togithub.com/WebAssembly/wasi-libc/issues/435)) * [`7b4705f1`](WebAssembly/wasi-libc@7b4705f) Fix typo in signal.c error messages ([WebAssembly/wasi-libc#437](https://togithub.com/WebAssembly/wasi-libc/issues/437)) * [`d4dae896`](WebAssembly/wasi-libc@d4dae89) add shared library support ([WebAssembly/wasi-libc#429](https://togithub.com/WebAssembly/wasi-libc/issues/429)) * [`6248a00c`](WebAssembly/wasi-libc@6248a00) Adjust Makefile for LLVM trunk (18) as of 2023-10-03 ([WebAssembly/wasi-libc#438](https://togithub.com/WebAssembly/wasi-libc/issues/438)) * [`4db5398e`](WebAssembly/wasi-libc@4db5398) remove `-nostdlib` from libc.so link command ([WebAssembly/wasi-libc#440](https://togithub.com/WebAssembly/wasi-libc/issues/440))
mergify bot
pushed a commit
that referenced
this issue
Oct 9, 2023
## Changelog for musl-wasi: Branch: main Commits: [WebAssembly/wasi-libc@ec4566be...4db5398e](WebAssembly/wasi-libc@ec4566b...4db5398) * [`ce2f157d`](WebAssembly/wasi-libc@ce2f157) Update thread id validation returned by `__wasi_thread_spawn` ([WebAssembly/wasi-libc#435](https://togithub.com/WebAssembly/wasi-libc/issues/435)) * [`7b4705f1`](WebAssembly/wasi-libc@7b4705f) Fix typo in signal.c error messages ([WebAssembly/wasi-libc#437](https://togithub.com/WebAssembly/wasi-libc/issues/437)) * [`d4dae896`](WebAssembly/wasi-libc@d4dae89) add shared library support ([WebAssembly/wasi-libc#429](https://togithub.com/WebAssembly/wasi-libc/issues/429)) * [`6248a00c`](WebAssembly/wasi-libc@6248a00) Adjust Makefile for LLVM trunk (18) as of 2023-10-03 ([WebAssembly/wasi-libc#438](https://togithub.com/WebAssembly/wasi-libc/issues/438)) * [`4db5398e`](WebAssembly/wasi-libc@4db5398) remove `-nostdlib` from libc.so link command ([WebAssembly/wasi-libc#440](https://togithub.com/WebAssembly/wasi-libc/issues/440))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #439 (comment), this reports no warnings:
but this does (and an error)
I think the fix involves also including
Diag.messages
in theOk
case ofcompile_result
.https://github.com/dfinity-lab/actorscript/blob/191e237b7028ecb8defb80153a358f4b6554cf39/src/pipeline.ml#L451
The text was updated successfully, but these errors were encountered: